-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2094856: rbd: create token and use it for vault SA #98
Bug 2094856: rbd: create token and use it for vault SA #98
Conversation
create the token if kubernetes version in 1.24+ and use it for vault sa. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> Signed-off-by: Rakshith R <rar@redhat.com> (cherry picked from commit 7a2dd4c)
@nixpanic: This pull request references Bugzilla bug 2094856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nixpanic please check the CI errors. |
Those issues are unrelated to this change. There are upstream improvements/corrections to the jobs, but there is no BZ we can use for backporting those changes to the downstream release-4.11. /assign yati1998 |
@yati1998: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@yati1998: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@nixpanic: All pull requests linked via external trackers have merged: Bugzilla bug 2094856 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.10 |
@Rakshith-R: new pull request created: #99 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
create the token if kubernetes version in 1.24+ and use it for vault sa.
I hereby confirm that:
explained its need very clearly